opencroft/sandbox-container
10
0
Fork 0
Code Issues Pull requests 1 Projects Releases Packages Wiki Activity Actions

fix(git-cred): defensive credential helper (SERVICE-16) #2

Open
freya wants to merge 1 commit from freya/defensive-git-cred-helper into main
pull from: freya/defensive-git-cred-helper
merge into: opencroft:main
Conversation 0 Commits 1 Files changed 1 +2 -1
freya commented 2026-08-05 11:37:31 +00:00
Owner
Copy link

Makes the baked-in credential helper safe. Previously /tmp/git-cred used ${!GIT_PASSWORD} (bash indirect expansion), which throws invalid indirect expansion whenever GIT_PASSWORD is unset; since git consults credential.helper before GIT_ASKPASS, that hijacked auth for any non-app git call in the container. Now it exits 0 with no output when GIT_PASSWORD is unset, so git falls through to askpass/prompt, and uses $GIT_PASSWORD directly. Ref: SERVICE-16.

Makes the baked-in credential helper safe. Previously /tmp/git-cred used ${!GIT_PASSWORD} (bash indirect expansion), which throws invalid indirect expansion whenever GIT_PASSWORD is unset; since git consults credential.helper before GIT_ASKPASS, that hijacked auth for any non-app git call in the container. Now it exits 0 with no output when GIT_PASSWORD is unset, so git falls through to askpass/prompt, and uses $GIT_PASSWORD directly. Ref: SERVICE-16.
This pull request can be merged automatically.
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin freya/defensive-git-cred-helper:freya/defensive-git-cred-helper
git switch freya/defensive-git-cred-helper

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch main
git merge --no-ff freya/defensive-git-cred-helper
git switch freya/defensive-git-cred-helper
git rebase main
git switch main
git merge --ff-only freya/defensive-git-cred-helper
git switch freya/defensive-git-cred-helper
git rebase main
git switch main
git merge --no-ff freya/defensive-git-cred-helper
git switch main
git merge --squash freya/defensive-git-cred-helper
git switch main
git merge --ff-only freya/defensive-git-cred-helper
git switch main
git merge freya/defensive-git-cred-helper
git push origin main
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
  
Status
Backlog

  
Status
Done

  
Status
InProgress

  
Status
InTest

  
Status
QA

  
Status
Review

  
Status
Todo

  
Type
Bug

  
Type
Task

No labels
Status
Backlog
Status
Done
Status
InProgress
Status
InTest
Status
QA
Status
Review
Status
Todo
Type
Bug
Type
Task
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
opencroft/sandbox-container!2
No description provided.